wangyang0918 commented on code in PR #191:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/191#discussion_r863872666


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java:
##########
@@ -87,8 +89,15 @@ public Configuration load(Key k) {
                                 });
 
         updateDefaultConfig(defaultConfig);
+        ScheduledExecutorService executorService = 
Executors.newSingleThreadScheduledExecutor();
+        executorService.scheduleWithFixedDelay(

Review Comment:
   Calling the `Cache#cleanUp()` periodically and cleaning up the tmp files in 
the `removalListener` could fix the issue in FLINK-27303. But actually the pod 
template, config, log tmp files are useless after the successful submission.
   
   Do you think we could clean up the tmp files more aggressive? Imagine the 
operator is managing thousand of jobs, the current implementation will still 
have so many tmp files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to