wangyang0918 commented on code in PR #191:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/191#discussion_r863874296
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java:
##########
@@ -87,8 +89,15 @@ public Configuration load(Key k) {
});
updateDefaultConfig(defaultConfig);
+ ScheduledExecutorService executorService =
Executors.newSingleThreadScheduledExecutor();
Review Comment:
It seems that the `executorService` is never shutdown. It might not be a
major problem because the `FlinkConfigManager` has the same lifecycle with
whole process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
