gyfora commented on code in PR #191:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/191#discussion_r863934809
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java:
##########
@@ -87,8 +89,15 @@ public Configuration load(Key k) {
});
updateDefaultConfig(defaultConfig);
+ ScheduledExecutorService executorService =
Executors.newSingleThreadScheduledExecutor();
+ executorService.scheduleWithFixedDelay(
Review Comment:
We could factor out the tmp file generation logic and always generate the
files right before submission and clean them up in a finally block. Probably
that would be the simplest.
We cannot simply delete the temp files because what if we roll back and get
a cached config for rollback submission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
