openinx commented on code in PR #117:
URL: https://github.com/apache/flink-table-store/pull/117#discussion_r869050446
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/format/FileFormatImpl.java:
##########
@@ -50,7 +54,12 @@ protected BulkDecodingFormat<RowData> getDecodingFormat() {
}
@Override
- protected EncodingFormat<BulkWriter.Factory<RowData>> getEncodingFormat() {
- return writerFactory.createEncodingFormat(null, formatOptions); //
context is useless
+ public FormatWriter.Factory<RowData> createWriterFactory(RowType
writeSchema) {
+ BulkWriter.Factory<RowData> bulkWriter =
+ writerFactory
+ .createEncodingFormat(null, formatOptions)
+ .createRuntimeEncoder(SINK_CONTEXT,
fromLogicalToDataType(writeSchema));
+
+ return new RowFormatWriter.RowFormatWriterFactory(bulkWriter,
writeSchema, null);
Review Comment:
The default `FileFormatImpl` don't have any general `FileStatsExtractor`, so
we just use the `null` by default. Finally, it will just use the
`FieldStatsCollector` to extract the column max-min.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
