JingsongLi commented on code in PR #117:
URL: https://github.com/apache/flink-table-store/pull/117#discussion_r875433467
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/manifest/ManifestFile.java:
##########
@@ -112,26 +120,17 @@ public void delete(String fileName) {
FileUtils.deleteOrWarn(pathFactory.toManifestFilePath(fileName));
}
- private class ManifestEntryBulkWriterFactory implements
BulkWriter.Factory<ManifestEntry> {
-
- @Override
- public BulkWriter<ManifestEntry> create(FSDataOutputStream out) throws
IOException {
- return new BaseBulkWriter<>(writerFactory.create(out),
serializer::toRow);
- }
- }
-
private class ManifestEntryWriter extends BaseFileWriter<ManifestEntry,
ManifestFileMeta> {
- private final FieldStatsCollector statsCollector;
-
+ private final FieldStatsCollector fieldStatsCollector;
Review Comment:
naming: `partitionStatsCollector`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
