rkhachatryan commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r873881105
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCompletedCheckpointStore.java:
##########
@@ -137,23 +134,19 @@ public CompletedCheckpoint
addCheckpointAndSubsumeOldestOne(
completedCheckpoints.addLast(checkpoint);
+ // Register checkpoint to SharedStateRegistry, and checkpoint would be
discarded during
+ // unregistering.
+ getSharedStateRegistry().registerCompletedCheckpoint(checkpoint);
+
+ // Remove completed checkpoint from queue and
checkpointStateHandleStore, not discard.
Optional<CompletedCheckpoint> subsume =
CheckpointSubsumeHelper.subsume(
completedCheckpoints,
maxNumberOfCheckpointsToRetain,
- completedCheckpoint ->
- tryRemoveCompletedCheckpoint(
- completedCheckpoint,
-
completedCheckpoint.shouldBeDiscardedOnSubsume(),
- checkpointsCleaner,
- postCleanup));
+ completedCheckpoint ->
tryRemove(completedCheckpoint.getCheckpointID()));
Review Comment:
In `shutdown()`, the store actually calls
`checkpointCleaner.cleanCheckpoint`, as opposed to adding a checkpoint, where
it only removes it from ZK.
After that, `shutdown()` calls `unregisterUnusedState` (line 200).
I wonder if there will be a duplicate call to cleanup a checkpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
