rkhachatryan commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r875289701
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java:
##########
@@ -227,6 +229,14 @@ private static void registerSharedState(
for (KeyedStateHandle stateHandle : stateHandles) {
if (stateHandle != null) {
stateHandle.registerSharedStates(sharedStateRegistry,
checkpointID);
+ // Registering state handle to the given sharedStateRegistry
serves two purposes:
+ // 1. let sharedStateRegistry be responsible for cleaning the
state handle,
Review Comment:
The ID is formally necessary to implement `equals` (`hashCode`). Otherwise,
each time this ID is used, `SharedStateRegistry` will try to discard it.
Discard is a no-op, but currently deletions are scheduled one-by-one to the
IO thread pool. So it might delay other IO tasks and/or lengthen the queue
inside the pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
