pnowojski commented on code in PR #19723:
URL: https://github.com/apache/flink/pull/19723#discussion_r879592425
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java:
##########
@@ -234,6 +265,11 @@ public void abortCheckpointOnBarrier(
() -> operatorChain.broadcastEvent(new
CancelCheckpointMarker(checkpointId)));
Review Comment:
> Should we move these 4 lines into runThrowing?
That's a good question. This method `abortCheckpointOnBarrier` is called
only from the `CheckpointBarrierHandler`, which is only used with network input
tasks, for which `actionExecutor` is always a no-op (it's being used only for
legacy sources in `SourceStreamTask`, which doesn't have network input). So I
think it doesn't matter really matter, but conceptually yes, it would be
technically more correct to wrap all of those lines with `actionExecutor`.
> And should we call cancelAlignmentTimer(); in close method?
Probably yes, to wake up anyone that might be waiting on the timer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
