JingsongLi commented on code in PR #133:
URL: https://github.com/apache/flink-table-store/pull/133#discussion_r878786902
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/format/FileFormat.java:
##########
@@ -53,10 +53,20 @@
*/
public abstract class FileFormat {
+ protected String formatIdentifier;
+
+ protected FileFormat(String formatIdentifier) {
+ this.formatIdentifier = formatIdentifier;
+ }
+
protected abstract BulkDecodingFormat<RowData> getDecodingFormat();
protected abstract EncodingFormat<BulkWriter.Factory<RowData>>
getEncodingFormat();
+ public String getSuffix() {
Review Comment:
Can we unify the naming? I see a lot of places where it's
`formatIdentifier`, but here it's `getSuffix`.
We can use `getFormatIdentifier` here.
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/DataFilePathFactory.java:
##########
@@ -34,20 +34,30 @@ public class DataFilePathFactory {
private final String uuid;
private final AtomicInteger pathCount;
+ private final String formatIdentifier;
public DataFilePathFactory(Path root, String partition, int bucket) {
Review Comment:
I think we can do without this constructor, the `formatIdentifier` is not a
nullable field, and the following can be done without having the special
treatment of null.
##########
flink-table-store-format/pom.xml:
##########
@@ -190,6 +190,13 @@ under the License.
</exclusion>
</exclusions>
</dependency>
+
+ <dependency>
+ <groupId>junit</groupId>
Review Comment:
Do we need this dependency? I see you are using junit 5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
