JingsongLi commented on code in PR #133:
URL: https://github.com/apache/flink-table-store/pull/133#discussion_r883213162
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/FileStorePathFactory.java:
##########
@@ -106,7 +114,12 @@ public Path toTmpSnapshotPath(long id) {
}
public DataFilePathFactory createDataFilePathFactory(BinaryRowData
partition, int bucket) {
- return new DataFilePathFactory(root, getPartitionString(partition),
bucket);
+ return createDataFilePathFactory(partition, bucket, formatIdentifier);
+ }
+
+ public DataFilePathFactory createDataFilePathFactory(
Review Comment:
Why introduce this method? There is a `formatIdentifier` in here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
