hililiwei commented on code in PR #133:
URL: https://github.com/apache/flink-table-store/pull/133#discussion_r882622802
##########
flink-table-store-format/pom.xml:
##########
@@ -190,6 +190,13 @@ under the License.
</exclusion>
</exclusions>
</dependency>
+
+ <dependency>
+ <groupId>junit</groupId>
Review Comment:
deleted
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/format/FileFormat.java:
##########
@@ -53,10 +53,20 @@
*/
public abstract class FileFormat {
+ protected String formatIdentifier;
+
+ protected FileFormat(String formatIdentifier) {
+ this.formatIdentifier = formatIdentifier;
+ }
+
protected abstract BulkDecodingFormat<RowData> getDecodingFormat();
protected abstract EncodingFormat<BulkWriter.Factory<RowData>>
getEncodingFormat();
+ public String getSuffix() {
Review Comment:
good, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
