yangjunhan commented on PR #19712: URL: https://github.com/apache/flink/pull/19712#issuecomment-1134499944
> These changes turn the Flink UI into a public API as the changes are clearly intended for outside usage to fully customize Flink UI, not for reusability within the Flink project. As such, I think this requires a FLIP and not just a JIRA issue. Thank you for the review! I have rearrange the PR into smaller logical commits that are easier to be reviewed :) . I also remove file changes which are irrelevant to the Jira ticket (those issues can be fixed in a separate PR). The main idea of this PR is to follow Angular's best Dependency Injection practice and refine the technical architecture of flink-runtime-web (make integration or so-called "reused" easily and so better advertisement :) ). Despite the size of it, this change is essentially related to pure Frontend technical refinement. FLIP should only be raised if one affects available features that user may use, but it won't even be acknowledged by them. As such, it could be a waste of our community resources to discuss a Frontend technical change **that won't affect our users**, so perhaps we can resolve this change here directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
