Airblader commented on PR #19712: URL: https://github.com/apache/flink/pull/19712#issuecomment-1135488515
> The main idea of this PR is to follow Angular's best Dependency Injection practice I disagree that having configuration for which components to render in specific locations is about some "DI best practice". Where is this supposed best practice coming from? Why are we doing it only for these specific components and not all other components? Making things configurable only makes sense when someone can (and wants to) actually change the configuration. The questions that need to be answered here are: who wants to modify this configuration and why? How would they be able to do so (how do you provide a custom component)? How do we ensure that this doesn't break in the future? Where is all of this documented? > this change is essentially related to pure Frontend technical refinement If we truly are making this change purely for technical reasons, I would oppose it as I see it as unnecessary complexity to have an indirection of which component to render even though we don't even use different configurations anywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
