simplejason commented on code in PR #19712:
URL: https://github.com/apache/flink/pull/19712#discussion_r880383726
##########
flink-runtime-web/web-dashboard/src/app/pages/job-manager/logs/job-manager-logs.component.ts:
##########
@@ -53,7 +67,9 @@ export class JobManagerLogsComponent implements OnInit,
OnDestroy {
this.cdr.markForCheck();
this.jobManagerService
.loadLogs()
- .pipe(takeUntil(this.destroy$))
+ .pipe(
+ catchError(() => of('')),
+ takeUntil(this.destroy$))
Review Comment:
`takeUntil` is no need to use since http request will complete by self.(It
already implements takeuntil internally)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
