1996fanrui commented on PR #19723: URL: https://github.com/apache/flink/pull/19723#issuecomment-1135530526
> Really nicely done :) LGTM. And thank you for your patience and addressing the feedback. Hi @pnowojski , It's my pleasure, and thanks a lot for your help. Currently, I have addressed your all comments and 2 checkState. We may also need to discuss the issue of the thread-safe problem of alignmentTimer in close method. Re `UnalignedCheckpointStressITCase`: Currently, `TestStreamEnvironment#randomizeConfiguration` has unaligned timeout config. [code link](https://github.com/apache/flink/blob/3c5d3bacda580de1dc4986909a0aa5fc30e37885/flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/TestStreamEnvironment.java#L113), it's added in [FLINK-19682](https://issues.apache.org/jira/browse/FLINK-19682). And I think you are right, it's very useful during developing. It can find some easily overlooked boundary conditions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
