1996fanrui commented on code in PR #19723:
URL: https://github.com/apache/flink/pull/19723#discussion_r880260528
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java:
##########
@@ -469,6 +550,7 @@ public void waitForPendingCheckpoints() throws Exception {
@Override
public void close() throws IOException {
+ cancelAlignmentTimer();
Review Comment:
Hi @pnowojski , I'm agree with you. And I have a small question.
If the new `close()` method call `cancelAlignmentTimer()`, do we need to
consider the thread-safe problem of alignmentTimer in close method. Although it
doesn't matter much here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
