[
https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446425#comment-15446425
]
ASF GitHub Bot commented on FLINK-4528:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2436
I am not sure I agree with this change.
There are cases when another class logically belongs to the RPC endpoint
(such as a connection utility). Being able to access the RPC execution context
allows one to treat both together as a "one operation at a time" unit. I think
that is pretty useful.
> Mark runAsync and scheduleAsync methods protected
> -------------------------------------------------
>
> Key: FLINK-4528
> URL: https://issues.apache.org/jira/browse/FLINK-4528
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> Currently, the {{runAsync}} and {{scheduleAsync}} methods of the
> {{RpcEndpoint}} are marked as public. I think that these methods should be
> protected since nobody should be able to influence the internal state of an
> {{RpcEndpoint}} from the outside via these methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
