[ 
https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452061#comment-15452061
 ] 

ASF GitHub Bot commented on FLINK-4528:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2436
  
    Yes, will do that.
    
    On Wed, Aug 31, 2016 at 1:50 PM, Stephan Ewen <[email protected]>
    wrote:
    
    > Okay, that makes sense.
    >
    > This would need to be updated then such that the ResourceManager passes
    > its MainThreadExecutionContext.
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/flink/pull/2436#issuecomment-243740478>, or 
mute
    > the thread
    > 
<https://github.com/notifications/unsubscribe-auth/AFfXugFJNjWpXGbo-_WO-kkQtxJsKACgks5qlWqCgaJpZM4Jvgqw>
    > .
    >



> Mark runAsync and scheduleAsync methods protected
> -------------------------------------------------
>
>                 Key: FLINK-4528
>                 URL: https://issues.apache.org/jira/browse/FLINK-4528
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> Currently, the {{runAsync}} and {{scheduleAsync}} methods of the 
> {{RpcEndpoint}} are marked as public. I think that these methods should be 
> protected since nobody should be able to influence the internal state of an 
> {{RpcEndpoint}} from the outside via these methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to