[
https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446540#comment-15446540
]
ASF GitHub Bot commented on FLINK-4528:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2436
I think that the `RpcEndpoint` should keep the control over which
components have access to its main thread and which not. Furthermore, limiting
the access to protected does not prohibit other components to use the main
thread execution context. The difference is simply that the `TaskExecutor` has
to actively give the context to the component instead of the component taking
it.
> Mark runAsync and scheduleAsync methods protected
> -------------------------------------------------
>
> Key: FLINK-4528
> URL: https://issues.apache.org/jira/browse/FLINK-4528
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> Currently, the {{runAsync}} and {{scheduleAsync}} methods of the
> {{RpcEndpoint}} are marked as public. I think that these methods should be
> protected since nobody should be able to influence the internal state of an
> {{RpcEndpoint}} from the outside via these methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
