Aitozi commented on code in PR #249:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886216711
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -640,8 +642,8 @@ public SavepointFetchResult fetchSavepointInfo(
}
}
Savepoint savepoint =
- new Savepoint(
- System.currentTimeMillis(),
response.get().resource().getLocation());
+ Savepoint.of(
+ response.get().resource().getLocation(),
SavepointTriggerType.UNKNOWN);
Review Comment:
I think the `UNKNOWN` type is only used for the zero value in the
`SavepointInfo`. We could use the correct SavepointTriggerType here directly ,
do not have to reset it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
