gyfora commented on code in PR #249:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886332488
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -653,7 +655,10 @@ public SavepointFetchResult fetchSavepointInfo(
public void disposeSavepoint(String savepointPath, Configuration conf)
throws Exception {
try (RestClusterClient<String> clusterClient =
(RestClusterClient<String>) getClusterClient(conf)) {
- clusterClient.disposeSavepoint(savepointPath);
+ clusterClient.sendRequest(
Review Comment:
The disposeSavepoint method of the RestClusterClient, first triggers the
dispose action and then keeps polling Flink until it completes.
The way we use it, this is completely unnecessary as we do not handle/retry
dispose actions from our side anyways. This way we can save some rest api calls.
However we lose the error logs unfortunately if the dispose actually failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
