SteNicholas commented on code in PR #249:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/249#discussion_r886359679
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java:
##########
@@ -286,17 +286,15 @@ private static boolean
jmMissingForRunningDeployment(FlinkDeployment deployment)
== JobManagerDeploymentStatus.MISSING);
}
- public static boolean isJobInTerminalState(FlinkDeploymentStatus status) {
+ public static boolean isJobInTerminalState(CommonStatus<?> status) {
var jobState = status.getJobStatus().getState();
return
org.apache.flink.api.common.JobStatus.valueOf(jobState).isGloballyTerminalState();
}
- public static boolean isJobRunning(FlinkDeploymentStatus status) {
- JobManagerDeploymentStatus deploymentStatus =
status.getJobManagerDeploymentStatus();
- return deploymentStatus == JobManagerDeploymentStatus.READY
- && org.apache.flink.api.common.JobStatus.RUNNING
- .name()
- .equals(status.getJobStatus().getState());
+ public static boolean isJobRunning(CommonStatus<?> status) {
+ return org.apache.flink.api.common.JobStatus.RUNNING
Review Comment:
Could this indeed represent wheter the job is running? IMO, this should
check with the task execution states in the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
