pnowojski commented on code in PR #19993:
URL: https://github.com/apache/flink/pull/19993#discussion_r899992947
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequest.java:
##########
@@ -109,6 +112,9 @@ static ChannelStateWriteRequest buildFutureWriteRequest(
}
},
throwable -> {
+ if (!dataFuture.isDone()) {
+ return;
+ }
Review Comment:
After a second thought interrupt can probably happen in this thread, when
the thread was operating normally/writing something and is being cancelled
(`ChannelStateWriteRequestExecutorImpl#close`). That's fine, interrupt can be
used to wake up the thread doing some normal operation (especially writing to a
file that can be blocked). What definitely shouldn't happen is interrupting
causing some resource leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
