1996fanrui commented on code in PR #19993:
URL: https://github.com/apache/flink/pull/19993#discussion_r900807989
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequest.java:
##########
@@ -98,6 +98,9 @@ static ChannelStateWriteRequest buildFutureWriteRequest(
List<Buffer> buffers;
try {
buffers = dataFuture.get();
+ } catch (InterruptedException e) {
+ writer.fail(e);
+ throw e;
Review Comment:
Hi @zentol @pnowojski , after I analyzed, I found we don't need change this.
This change compared to before just calling `writer.fail(e);` when
InterruptedException is caught. The previous code did not catch
InterruptedException, so it will continue to throw when InterruptedException is
encountered.
We don't need call the `writer.fail(e);` when InterruptedException is
caught. Because the `dispatcher.fail()` will be called before
ChannelStateWriteThread dead. [code
link](https://github.com/apache/flink/blob/3ae4c6f5a48105d00807e8ce02e70d4c092cbf40/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java#L83).
The dispatcher.fail will call all writers's fail() method, so I think these
change isn't necessary. I will revert it in next commit. We will focus on next
change, that is, improve the discardAction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
