[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458228#comment-15458228
]
ASF GitHub Bot commented on FLINK-4505:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2461
Thanks for the contribution @wangzhijiang999.
I think the abstraction is not right. The `StandaloneFactory` and the
`YarnFactory` should actually only differ in the class of the `TaskExecutor`
they start. Furthermore, I think that the network interface selection should
not be part of the factory. Instead I would pass the hostname and port to the
`createTaskManager(hostname, port)` method which constructs the `TaskManager`.
Maybe it makes even sense to pass the `RpcService` via the
`createTaskManager(RpcService)` and defer the RpcService creation to the
outside method running the select interface method.
The difference between the Standalone/Yarn and Testing factory is that the
first two create the TM components whereas the `TestingFactory` is initialized
with the `TaskManager` components.
> Implement TaskManagerFactory to bring up TaskManager for different modes
> ------------------------------------------------------------------------
>
> Key: FLINK-4505
> URL: https://issues.apache.org/jira/browse/FLINK-4505
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Zhijiang Wang
> Assignee: Zhijiang Wang
> Priority: Minor
>
> Implement {{TaskExecutorFactory}} that should be an abstract class with the
> helper methods to bring up the {{TaskManager}}. The factory can be
> implemented by some classes to start a {{TaskManager}} in different modes
> (testing, standalone, yarn).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
