[ 
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458340#comment-15458340
 ] 

ASF GitHub Bot commented on FLINK-4505:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2461
  
    I think we don't need the distinction between standalone and yarn in the 
TaskManager startup. They should actually be the same. The difference will be 
the `StandaloneRunner`, `YarnRunner` and `MesosRunner`.
    
    I think the factory should be responsible for creating the `TaskManager` 
components. I would pull out the `RpcService` creation and, thus, also the 
network interface selection, because this is code which can be re-used across 
different components (TM and JM, for example).


> Implement TaskManagerFactory to bring up TaskManager for different modes
> ------------------------------------------------------------------------
>
>                 Key: FLINK-4505
>                 URL: https://issues.apache.org/jira/browse/FLINK-4505
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>            Priority: Minor
>
> Implement {{TaskExecutorFactory}} that should be an abstract class with the 
> helper methods to bring up the {{TaskManager}}. The factory can be 
> implemented by some classes to start a {{TaskManager}} in different modes 
> (testing, standalone, yarn).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to