[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466924#comment-15466924
]
ASF GitHub Bot commented on FLINK-4505:
---------------------------------------
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2461
@tillrohrmann , I created the `TaskExecutorRunner` for constructing the
related components for starting `TaskExecutor`, and removed the factory class.
Currently only the `ResourceID` and 'Configuration` parameters must be passed
to the method `startComponents`, other parameters are optional. After you
confirm the way , I will write some testings based on it.
The `MemoryLogger` is removed from `TaskExecutorRunner` temporarily. The
`ActorGateway` should not be passed to the constructor of `MemoryLogger`
directly I think. If you agree, I will re-structure the `MemoryLogger` in
another jira.
> Implement TaskManagerFactory to bring up TaskManager for different modes
> ------------------------------------------------------------------------
>
> Key: FLINK-4505
> URL: https://issues.apache.org/jira/browse/FLINK-4505
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Zhijiang Wang
> Assignee: Zhijiang Wang
> Priority: Minor
>
> Implement {{TaskExecutorFactory}} that should be an abstract class with the
> helper methods to bring up the {{TaskManager}}. The factory can be
> implemented by some classes to start a {{TaskManager}} in different modes
> (testing, standalone, yarn).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)