dannycranmer commented on code in PR #20133:
URL: https://github.com/apache/flink/pull/20133#discussion_r912129547
##########
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java:
##########
@@ -149,7 +149,9 @@ public void run() {
// we can close this consumer thread once we've reached
the end of the
// subscribed shard
break;
- } else if (result == CANCELLED) {
+ } else if (result == CANCELLED && isRunning()) {
+ // cancellation might be signalled as part of graceful
shutdown during
+ // stop-with-savepoint, we should ignore it when the
consumer is not running
final String errorMessage =
"Shard consumer cancelled: " +
subscribedShard.getShard().getShardId();
Review Comment:
Can you please add a unit test for this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
