dannycranmer commented on code in PR #20133:
URL: https://github.com/apache/flink/pull/20133#discussion_r912129760
##########
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/FanOutRecordPublisher.java:
##########
@@ -154,7 +155,8 @@ private RecordPublisherRunResult runWithBackoff(
fanOutShardSubscriber.subscribeToShardAndConsumeRecords(
toSdkV2StartingPosition(nextStartingPosition),
eventConsumer);
attempt = 0;
- } catch (FanOutSubscriberInterruptedException ex) {
+ } catch (FanOutSubscriberInterruptedException |
RejectedExecutionException ex) {
+ // RejectedExecutionException occurs during soft shutdown, e.g.
stop with savepoint
Review Comment:
Can you please add a unit test for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
