JingsongLi commented on code in PR #182:
URL: https://github.com/apache/flink-table-store/pull/182#discussion_r914351318
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/AbstractFileStoreScan.java:
##########
@@ -272,4 +272,15 @@ private boolean filterByBucket(ManifestEntry entry) {
private List<ManifestEntry> readManifestFileMeta(ManifestFileMeta
manifest) {
return manifestFileFactory.create().read(manifest.fileName());
}
+
+ private List<ManifestFileMeta> readIncremental(Long snapshotId) {
Review Comment:
I think it is better to throw exception.
From an API perspective, this semantics you describe is too complex and we
don't rely on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
