JingsongLi commented on code in PR #182:
URL: https://github.com/apache/flink-table-store/pull/182#discussion_r914358445
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java:
##########
@@ -216,15 +216,32 @@ public class CoreOptions implements Serializable {
"The size amplification is defined as the amount
(in percentage) of additional storage "
+ "needed to store a single byte of data
in the merge tree.");
- public static final ConfigOption<Integer> COMPACTION_SIZE_RATIO =
- ConfigOptions.key("compaction.size-ratio")
+ public static final ConfigOption<Integer> COMPACTION_SORTED_RUN_SIZE_RATIO
=
Review Comment:
`COMPACTION_MAX_SIZE_AMPLIFICATION_PERCENT` and `COMPACTION_SIZE_RATIO` are
for changelog mode.
I think we can just add note in description. `for changelog mode table.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
