afedulov commented on code in PR #20127:
URL: https://github.com/apache/flink/pull/20127#discussion_r915200376
##########
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvFormatOptions.java:
##########
@@ -87,5 +87,11 @@ public class CsvFormatOptions {
"Optional null literal string that is interpreted
as a\n"
+ "null value (disabled by default)");
+ public static final ConfigOption<Boolean> WRITE_BIGDECIMAL_AS_PLAIN =
+ ConfigOptions.key("write-bigdecimal-as-plain")
+ .booleanType()
+ .defaultValue(true)
Review Comment:
This option is set to false [in Jackson by
default](https://fasterxml.github.io/jackson-core/javadoc/2.7/com/fasterxml/jackson/core/JsonGenerator.Feature.html#:~:text=disabled%20by%20default.-,WRITE_BIGDECIMAL_AS_PLAIN,-public%20static%20final)
Don't you think this might cause issues for the users to expect the
"standard" Jackson CSV behavior out of the box?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
