afedulov commented on code in PR #20127:
URL: https://github.com/apache/flink/pull/20127#discussion_r916736460
##########
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvFormatOptions.java:
##########
@@ -87,11 +87,12 @@ public class CsvFormatOptions {
"Optional null literal string that is interpreted
as a\n"
+ "null value (disabled by default)");
- public static final ConfigOption<Boolean> WRITE_BIGDECIMAL_AS_PLAIN =
- ConfigOptions.key("write-bigdecimal-as-plain")
+ public static final ConfigOption<Boolean>
DISABLE_WRITE_BIGDECIMAL_AS_SCIENTIFIC_NOTATION =
Review Comment:
Why not just `WRITE_BIGDECIMAL_IN_SCIENTIFIC_NOTATION` without DISABLE? The
boolean already incorporates the notion of on/off and I do not see a benefit in
negating the predicate that clearly states the outcome. (also mind IN instead
of AS)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
