afedulov commented on code in PR #20127:
URL: https://github.com/apache/flink/pull/20127#discussion_r916163668
##########
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvFormatOptions.java:
##########
@@ -87,5 +87,11 @@ public class CsvFormatOptions {
"Optional null literal string that is interpreted
as a\n"
+ "null value (disabled by default)");
+ public static final ConfigOption<Boolean> WRITE_BIGDECIMAL_AS_PLAIN =
+ ConfigOptions.key("write-bigdecimal-as-plain")
+ .booleanType()
+ .defaultValue(true)
Review Comment:
Are you sure? I see that our default value is `true`, whereas Jackson sets
it to false.
https://github.com/FasterXML/jackson-core/blob/2.13/src/main/java/com/fasterxml/jackson/core/JsonGenerator.java
BTW, we can probably also reuse a part of their JavaDoc for this option
almost verbatim. We just pass it through to Jackson anyhow, so there is no
need to invent a different interpretation, but it is up to you:
https://github.com/FasterXML/jackson-core/blob/2.13/src/main/java/com/fasterxml/jackson/core/JsonGenerator.java#L188-L190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
