Github user mxm commented on a diff in the pull request:
    --- Diff: 
    @@ -79,9 +82,8 @@ public static void install(SecurityConfiguration config) 
throws Exception {
                JaasConfiguration jaasConfig = new 
JaasConfiguration(config.keytab, config.principal);
    -           //hack since Kafka Login Handler explicitly looks for the 
property or else it throws an exception
    -           System.setProperty("", "");
    +           //temporary fix
    +           populateJaasConfigSystemProperty(config.flinkConf);
    --- End diff --
    From my experience comments like "temporary fix" tend to stay forever. I 
would replace it with something that explains the reasoning. That helps to fix 
the code when it is reviewed later on.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to