Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2275#discussion_r79356049
  
    --- Diff: 
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
    @@ -374,7 +409,39 @@ public static void startYARNWithConfig(Configuration 
conf) {
                        File flinkConfDirPath = findFile(flinkDistRootDir, new 
ContainsName(new String[]{"flink-conf.yaml"}));
                        Assert.assertNotNull(flinkConfDirPath);
     
    -                   map.put(ConfigConstants.ENV_FLINK_CONF_DIR, 
flinkConfDirPath.getParent());
    +                   if(!StringUtils.isBlank(principal) && 
!StringUtils.isBlank(keytab)) {
    +                           //copy conf dir to test temporary workspace 
location
    +                           tempConfPathForSecureRun = 
tmp.newFolder("conf");
    +
    +                           String confDirPath = 
flinkConfDirPath.getParentFile().getAbsolutePath();
    +                           FileUtils.copyDirectory(new File(confDirPath), 
tempConfPathForSecureRun);
    +
    +                           try(FileWriter fw = new FileWriter(new 
File(tempConfPathForSecureRun,"flink-conf.yaml"), true);
    +                                   BufferedWriter bw = new 
BufferedWriter(fw);
    +                                   PrintWriter out = new PrintWriter(bw))
    +                           {
    +                                   LOG.info("writing keytab: " + keytab + 
" and principal: " + principal + " to config file");
    +                                   out.println("");
    +                                   out.println("#Security Configurations 
Auto Populated ");
    +                                   
out.println(ConfigConstants.SECURITY_KEYTAB_KEY + ": " + keytab);
    +                                   
out.println(ConfigConstants.SECURITY_PRINCIPAL_KEY + ": " + principal);
    +                                   out.println("");
    +                           } catch (IOException e) {
    +                                   LOG.error("Exception occured while 
trying to append the security configurations. Reason: {}", e.getMessage());
    --- End diff --
    
    Should be `LOG.error("Exception occured while trying to append the security 
configurations.", e);`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to