Github user vijikarthi commented on a diff in the pull request:
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/ ---
    @@ -1233,6 +1239,9 @@
        /** ZooKeeper default leader port. */
        public static final int DEFAULT_ZOOKEEPER_LEADER_PORT = 3888;
    +   /** Defaults for ZK client security **/
    +   public static final boolean DEFAULT_ZOOKEEPER_SASL_DISABLE = true;
    --- End diff --
    I agree but it can be argued both ways. We could keep the default to false 
(enable SASL client auth if not disabled explicitly through configuration file) 
or expect an explicit ask to enable SASL through the configuration settings. I 
chose later since secure ZK is not a common deployment (mostly) and moreover we 
also have introduced new security configurations to enable security and one 
could configure/adjust ZK configuration at that time. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to