snuyanzin commented on code in PR #20168:
URL: https://github.com/apache/flink/pull/20168#discussion_r968207924
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java:
##########
@@ -358,8 +370,9 @@ public void testBatchQueryExecution() throws Exception {
}
}
- @Test(timeout = 90_000L)
- public void testBatchQueryExecutionMultipleTimes() throws Exception {
+ @Test
+ @Timeout(90)
Review Comment:
Since JUnit 5 supports specification of timeunits it would be much more
convenient (code will be more readable) to use them like
```java
@Timeout(value = 90, unit = TimeUnit.SECONDS)
```
or
```java
@Timeout(value = 90, unit = TimeUnit.MILLISECONDS)
```
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java:
##########
@@ -312,8 +323,9 @@ public void testStreamQueryExecutionLimitedTable() throws
Exception {
executeStreamQueryTable(replaceVars, configMap, query,
expectedResults);
}
- @Test(timeout = 90_000L)
- public void testBatchQueryExecution() throws Exception {
+ @Test
+ @Timeout(90)
Review Comment:
Since JUnit 5 supports specification of timeunits it would be much more
convenient to use them like
```java
@Timeout(value = 90, unit = TimeUnit.SECONDS)
```
or
```java
@Timeout(value = 90, unit = TimeUnit.MILLISECONDS)
```
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java:
##########
@@ -291,8 +301,9 @@ public void testStreamQueryExecutionTableMultipleTimes()
throws Exception {
}
}
- @Test(timeout = 90_000L)
- public void testStreamQueryExecutionLimitedTable() throws Exception {
+ @Test
+ @Timeout(90)
Review Comment:
Since JUnit 5 supports specification of timeunits it would be much more
convenient to use them like
```java
@Timeout(value = 90, unit = TimeUnit.SECONDS)
```
or
```java
@Timeout(value = 90, unit = TimeUnit.MILLISECONDS)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
