snuyanzin commented on code in PR #20168:
URL: https://github.com/apache/flink/pull/20168#discussion_r968208180
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java:
##########
@@ -265,8 +274,9 @@ public void testStreamQueryExecutionTable() throws
Exception {
executeStreamQueryTable(replaceVars, configMap, query,
expectedResults);
}
- @Test(timeout = 90_000L)
- public void testStreamQueryExecutionTableMultipleTimes() throws Exception {
+ @Test
+ @Timeout(90)
Review Comment:
Since JUnit 5 supports specification of timeunits it would be much more
convenient to use them like
```java
@Timeout(value = 90, unit = TimeUnit.SECONDS)
```
or
```java
@Timeout(value = 90, unit = TimeUnit.MILLISECONDS)
```
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java:
##########
@@ -240,8 +248,9 @@ public void
testStreamQueryExecutionChangelogMultipleTimes() throws Exception {
}
}
- @Test(timeout = 90_000L)
- public void testStreamQueryExecutionTable() throws Exception {
+ @Test
+ @Timeout(90)
Review Comment:
Since JUnit 5 supports specification of timeunits it would be much more
convenient to use them like
```java
@Timeout(value = 90, unit = TimeUnit.SECONDS)
```
or
```java
@Timeout(value = 90, unit = TimeUnit.MILLISECONDS)
```
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java:
##########
@@ -191,8 +198,9 @@ public void testStreamQueryExecutionChangelog() throws
Exception {
}
}
- @Test(timeout = 90_000L)
- public void testStreamQueryExecutionChangelogMultipleTimes() throws
Exception {
+ @Test
+ @Timeout(90)
Review Comment:
Since JUnit 5 supports specification of timeunits it would be much more
convenient to use them like
```java
@Timeout(value = 90, unit = TimeUnit.SECONDS)
```
or
```java
@Timeout(value = 90, unit = TimeUnit.MILLISECONDS)
```
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java:
##########
@@ -144,8 +150,9 @@ public void testCompleteStatement() {
executor.closeSession(sessionId);
}
- @Test(timeout = 90_000L)
- public void testStreamQueryExecutionChangelog() throws Exception {
+ @Test
+ @Timeout(90)
Review Comment:
Since JUnit 5 supports specification of timeunits it would be much more
convenient to use them like
```java
@Timeout(value = 90, unit = TimeUnit.SECONDS)
```
or
```java
@Timeout(value = 90, unit = TimeUnit.MILLISECONDS)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
