snuyanzin commented on code in PR #20168:
URL: https://github.com/apache/flink/pull/20168#discussion_r968211878
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java:
##########
@@ -231,8 +234,9 @@ public void testIllegalStatementInInitFile() throws
Exception {
assertThat(cliClient.executeInitialization(content)).isFalse();
}
- @Test(timeout = 10000)
- public void testCancelExecutionInNonInteractiveMode() throws Exception {
+ @Test
+ @Timeout(10000)
Review Comment:
By Default JUnit4 works with millis while JUnit 5 works with seconds...
that's why I would suggest to specify timeunits since JUnit 5 supports
specification of timeunits it would be much more convenient to use them like
```java
@Timeout(value = 10, unit = TimeUnit.SECONDS)
```
or
```java
@Timeout(value = 10000, unit = TimeUnit.MILLISECONDS)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
