zentol commented on code in PR #20810:
URL: https://github.com/apache/flink/pull/20810#discussion_r968353797
##########
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java:
##########
@@ -85,15 +85,16 @@ static void shutdown() throws InterruptedException,
ExecutionException, TimeoutE
// ------------------------------------------------------------------------
// tests
// ------------------------------------------------------------------------
-
@Test
void testScheduleRunnable() throws Exception {
Review Comment:
> We could check whether AkkaRpcService#getScheduledExecutor returns a
ActorSystemScheduledExecutorAdapter to be on the safe side. ...since that's
some kind of implementation detail that we might want to ensure. thinking
It doesn't matter what kind of executor class it returns, so long as it
adheres to the contract of setting the context classloader. We'd just be
testing implementation details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
