zentol commented on code in PR #20810:
URL: https://github.com/apache/flink/pull/20810#discussion_r968380569


##########
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java:
##########
@@ -85,15 +85,16 @@ static void shutdown() throws InterruptedException, 
ExecutionException, TimeoutE
     // ------------------------------------------------------------------------
     //  tests
     // ------------------------------------------------------------------------
-
     @Test
     void testScheduleRunnable() throws Exception {

Review Comment:
   Arguably we could test it in ActorSystemScheduledExecutorAdapterTest and 
assert that the rpc service returns a ActorSystemScheduledExecutorAdapter, but 
it feels strange to do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to