zentol commented on code in PR #20810:
URL: https://github.com/apache/flink/pull/20810#discussion_r968356756
##########
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java:
##########
@@ -85,15 +85,16 @@ static void shutdown() throws InterruptedException,
ExecutionException, TimeoutE
// ------------------------------------------------------------------------
// tests
// ------------------------------------------------------------------------
-
@Test
void testScheduleRunnable() throws Exception {
Review Comment:
> I'm wondering whether we should move this test into
ActorSystemScheduledExecutorAdapterTest instead of having this being tested in
AkkaRpcServiceTest thinking
We'd need these tests anyway on the rpc service level (to ensure it actually
uses something internally to ensure the context CL setting), so we'd just
duplicate tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
