kylemeow commented on code in PR #20542:
URL: https://github.com/apache/flink/pull/20542#discussion_r972689559
##########
flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseSinkFunction.java:
##########
@@ -213,6 +225,7 @@ public void close() throws Exception {
if (mutator != null) {
try {
+ flush();
Review Comment:
Hi @dannycranmer , personally I reckon this might not be an issue because
according to the documentation, the `close()` method of mutator inherently
flushes buffered data to the HBase server before closing the connection, so the
flush logic is already there before this PR.
Also, as it is already in the `try ... catch` block, when an `IOException`
is thrown by the client during the flush, the job-stopping process would not be
interrupted as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
