kylemeow commented on code in PR #20542:
URL: https://github.com/apache/flink/pull/20542#discussion_r974839709
##########
flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseSinkFunction.java:
##########
@@ -191,8 +195,10 @@ private void checkErrorAndRethrow() {
public void invoke(T value, Context context) throws Exception {
checkErrorAndRethrow();
- mutator.mutate(mutationConverter.convertToMutation(value));
-
+ Mutation mutation = mutationConverter.convertToMutation(value);
+ synchronized (mutationMap) {
+ mutationMap.put(mutation.getRow(), mutation);
Review Comment:
One potential bug might arise when the `mutation.getRow()` returns an array.
As we know, the `hashCode` and `equals` of two different array instances are
different regardless of whether their contents are identical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
