lsyldliu commented on code in PR #20884:
URL: https://github.com/apache/flink/pull/20884#discussion_r978203393
##########
docs/content/docs/connectors/table/jdbc.md:
##########
@@ -211,30 +211,48 @@ Connector Options
<a
href="https://jdbc.postgresql.org/documentation/head/query.html#query-with-cursor";>Postgres</a>,
may require this to be set to false in order to stream results.</td>
</tr>
<tr>
- <td><h5>lookup.cache.max-rows</h5></td>
+ <td><h5>lookup.cache</h5></td>
+ <td>optional</td>
+ <td>yes</td>
+ <td style="word-wrap: break-word;">NONE</td>
+ <td><p>Enum</p>Possible values: NONE, PARTIAL</td>
Review Comment:
I think here we should list the three enum values, but explain only support
the prior two strategies. WDYT?
##########
docs/content/docs/connectors/table/hbase.md:
##########
@@ -188,20 +188,48 @@ Connector Options
<td>Whether async lookup are enabled. If true, the lookup will be async.
Note, async only supports hbase-2.2 connector.</td>
</tr>
<tr>
- <td><h5>lookup.cache.max-rows</h5></td>
+ <td><h5>lookup.cache</h5></td>
<td>optional</td>
<td>yes</td>
- <td style="word-wrap: break-word;">-1</td>
+ <td style="word-wrap: break-word;">NONE</td>
+ <td><p>Enum</p>Possible values: NONE, PARTIAL</td>
Review Comment:
ditto
##########
docs/content/docs/connectors/table/hbase.md:
##########
@@ -188,20 +188,48 @@ Connector Options
<td>Whether async lookup are enabled. If true, the lookup will be async.
Note, async only supports hbase-2.2 connector.</td>
</tr>
<tr>
- <td><h5>lookup.cache.max-rows</h5></td>
+ <td><h5>lookup.cache</h5></td>
<td>optional</td>
<td>yes</td>
- <td style="word-wrap: break-word;">-1</td>
+ <td style="word-wrap: break-word;">NONE</td>
+ <td><p>Enum</p>Possible values: NONE, PARTIAL</td>
+ <td>The cache strategy for the lookup table. Currently supports NONE (no
caching) and PARTIAL (caching entries on lookup operation in external
database).</td>
+ </tr>
+ <tr>
+ <td><h5>lookup.partial-cache.max-rows</h5></td>
Review Comment:
Refer to
https://github.com/apache/flink/blob/bf81768ff564c5bf4a57cb33c6f5126b83b28fb5/flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/table/HBaseConnectorOptions.java#L98,
I think we should also explain the old compatible options instead of dropping
it directly. Other deprecated options are similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
