PatrickRen commented on code in PR #20884:
URL: https://github.com/apache/flink/pull/20884#discussion_r978237058
##########
docs/content/docs/connectors/table/hbase.md:
##########
@@ -188,20 +188,48 @@ Connector Options
<td>Whether async lookup are enabled. If true, the lookup will be async.
Note, async only supports hbase-2.2 connector.</td>
</tr>
<tr>
- <td><h5>lookup.cache.max-rows</h5></td>
+ <td><h5>lookup.cache</h5></td>
<td>optional</td>
<td>yes</td>
- <td style="word-wrap: break-word;">-1</td>
+ <td style="word-wrap: break-word;">NONE</td>
+ <td><p>Enum</p>Possible values: NONE, PARTIAL</td>
+ <td>The cache strategy for the lookup table. Currently supports NONE (no
caching) and PARTIAL (caching entries on lookup operation in external
database).</td>
+ </tr>
+ <tr>
+ <td><h5>lookup.partial-cache.max-rows</h5></td>
Review Comment:
I think keeping some deprecated options in the doc is a bit weird too, as we
should "push" users to switch to new options asap. We keep these deprecated
options in the code just for backward compatibility. Users can always refer to
doc of previous versions to get the definition of those deprecated options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
