PatrickRen commented on code in PR #20884:
URL: https://github.com/apache/flink/pull/20884#discussion_r978302806
##########
docs/content/docs/connectors/table/hbase.md:
##########
@@ -188,20 +188,48 @@ Connector Options
<td>Whether async lookup are enabled. If true, the lookup will be async.
Note, async only supports hbase-2.2 connector.</td>
</tr>
<tr>
- <td><h5>lookup.cache.max-rows</h5></td>
+ <td><h5>lookup.cache</h5></td>
<td>optional</td>
<td>yes</td>
- <td style="word-wrap: break-word;">-1</td>
+ <td style="word-wrap: break-word;">NONE</td>
+ <td><p>Enum</p>Possible values: NONE, PARTIAL</td>
+ <td>The cache strategy for the lookup table. Currently supports NONE (no
caching) and PARTIAL (caching entries on lookup operation in external
database).</td>
+ </tr>
+ <tr>
+ <td><h5>lookup.partial-cache.max-rows</h5></td>
Review Comment:
Thanks for the feedback! Of course users don't need to read the code to get
the mapping. Both deprecated and new options are descriptive enough in the doc
to be translated between. Anyhow I get your point to make the migration more
smooth. I'll add a new section to show which deprecated option the new one is
mapping to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
