leletan commented on code in PR #20852:
URL: https://github.com/apache/flink/pull/20852#discussion_r979107588
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java:
##########
@@ -878,7 +879,8 @@ public CompletableFuture<String> triggerSavepoint(
}
@Override
- public CompletableFuture<String> triggerCheckpoint() {
+ public CompletableFuture<CompletedCheckpoint> triggerCheckpoint(
Review Comment:
Hmm, good question ... I was just following the same function call path as
triggerSavepoint (resful -> dispatcher -> job master -> scheduler -> checkpoint
coordinator).
@stevenzwu Are you suggesting we skip scheduler and call
CheckpointCoordinator::triggerCheckpoint(...) directly from job master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
