leletan commented on code in PR #20852:
URL: https://github.com/apache/flink/pull/20852#discussion_r980350376
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##########
@@ -863,11 +871,6 @@ public CompletableFuture<String> triggerSavepoint(
return schedulerNG.triggerSavepoint(targetDirectory, cancelJob,
formatType);
}
- @Override
Review Comment:
Double checked the code - the backward compatibility should already been
kept. At this class's parent interface `JobMasterGateway`, this method is
supported as
```
/**
* Triggers taking a checkpoint of the executed job.
*
* @param timeout for the rpc call
* @return Future which is completed with the checkpoint path once
completed
*/
default CompletableFuture<String> triggerCheckpoint(@RpcTimeout final
Time timeout) {
return triggerCheckpoint(null,
timeout).thenApply(CompletedCheckpoint::getExternalPointer);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
